Skip to content

Improve testing framework#11909

Open
PerfectSlayer wants to merge 5 commits into
masterfrom
bbujon/groovy-to-java
Open

Improve testing framework#11909
PerfectSlayer wants to merge 5 commits into
masterfrom
bbujon/groovy-to-java

Conversation

@PerfectSlayer

@PerfectSlayer PerfectSlayer commented Jul 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

What Does This Do

This PR improves the Junit / Java testing framework by:

  • measured and top-level status check
  • fixing span link assertions
  • using constant references rather than litteral
  • splitting JUnit util module to no longe depend on dd-trace-api and internal-api
  • moving matchers to utils modules to be reused late by later smoke test tooling

Motivation

Keep enriching the testing API while maintaining design clear.

Additional Notes

Another PR with smoke test improvements coming.

Contributor Checklist

Jira ticket: APMLP-1247

@PerfectSlayer PerfectSlayer added type: feature Enhancements and improvements comp: testing Testing tag: no release notes Changes to exclude from release notes labels Jul 10, 2026
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented Jul 12, 2026 •
edited by datadog-prod-us1-4 Bot
Loading

Copy link
Copy Markdown
Contributor

🎯 Code Coverage (details)
• Patch Coverage: 100.00%
• Overall Coverage: 56.91% (-0.13%)

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 1e24d42 | Docs | Datadog PR Page | Give us feedback!

@dd-octo-sts

dd-octo-sts Bot commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

🟢 Java Benchmark SLOs — All performance SLOs passed

Suite Status
Startup 🟢 pass

SLO thresholds are defined here based on automatically generated metrics. A warning is raised when results are within 5% of the threshold.

PR vs. master results
Scenario Candidate master Δ (95% CI of mean)
startup:insecure-bank:iast:Agent 13.99 s 14.02 s [-1.0%; +0.6%] (no difference)
startup:insecure-bank:tracing:Agent 13.03 s 13.05 s [-0.8%; +0.5%] (no difference)
startup:petclinic:appsec:Agent 16.90 s 16.67 s [+0.3%; +2.5%] (maybe worse)
startup:petclinic:iast:Agent 16.85 s 16.95 s [-1.6%; +0.4%] (no difference)
startup:petclinic:profiling:Agent 16.84 s 16.86 s [-1.4%; +1.2%] (no difference)
startup:petclinic:sca:Agent 16.43 s 16.51 s [-6.8%; +5.7%] (unstable)
startup:petclinic:tracing:Agent 16.08 s 16.08 s [-0.8%; +0.8%] (no difference)

Commit: 1e24d42c · CI Pipeline · Benchmarking Platform UI

Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion.

@PerfectSlayer PerfectSlayer marked this pull request as ready for review July 14, 2026 11:00
@PerfectSlayer PerfectSlayer requested review from a team as code owners July 14, 2026 11:00
@PerfectSlayer PerfectSlayer requested review from mcculls and ygree and removed request for a team July 14, 2026 11:00
datadog-datadog-prod-us1[bot]
datadog-datadog-prod-us1 Bot reviewed Jul 14, 2026
View reviewed changes

@datadog-datadog-prod-us1 datadog-datadog-prod-us1 Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Datadog Autotest: PASS

More details

The pre-existing linkMatchers[expectedLinkCount] index bug in assertSpanLinks (which would throw ArrayIndexOutOfBoundsException on any test calling .links(...)) is definitively confirmed fixed: standalone execution showed the old code path always throws AIOOBE, the new linkMatchers[i] path iterates correctly. The measured()/topLevel() additions and module reorganization are behaviorally sound with no regressions — all callers updated, no orphaned old-package references remain.

Was this helpful? React 👍 or 👎

📊 Validated against 8 scenarios · Open Bits AI session

🤖 Datadog Autotest · Commit 1e24d42 · What is Autotest? · Any feedback? Reach out in #autotest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@datadog-datadog-prod-us1 datadog-datadog-prod-us1[bot] datadog-datadog-prod-us1[bot] left review comments
@mcculls mcculls Awaiting requested review from mcculls mcculls is a code owner automatically assigned from DataDog/apm-sdk-capabilities-java
@ygree ygree Awaiting requested review from ygree ygree is a code owner automatically assigned from DataDog/apm-idm-java

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: feature Enhancements and improvements

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@PerfectSlayer